Fix socket bugs caused by switching to a newer MSVC compiler #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows uses different error codes than Unix does, and our socket code was only checking for Unix errors by number. This was causing some things to fail that should have worked. I believe that in the newer Python's that these errors are folded from the Windows errors to Unix errors, but I can't find where to do that here in Python2.
icanhasmath
reviewed
Jun 18, 2024
rickprice
force-pushed
the
BE-3962-python-2-core-async
branch
from
aba4248 to
115210b
Compare
icanhasmath
approved these changes
Jun 21, 2024
icanhasmath
left a comment
icanhasmath
left a comment
There was a problem hiding this comment.
Looks good - we can look into reverting this if we can solve this issue globally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix problem where Windows returns different error codes than Unix does, and our Socked calls were only checking for Unix codes instead of Unix AND Windows codes.
There may be a better fix for this, but I need to talk to Jeremy.
These errors were probably caused by using a newer MSVC compiler.