Skip to content

Conversation

@rickprice
Copy link

Windows only seems to return WSAE* errors, so we need to check for these
errors on Windows.

However the WSAE* error definitions only exist on Windows, they do not
exist on Posix.

Trying to import them causes a failure on Posix.

On Posix, we now just reassign the WSAE* error values to the normal E*
values, letting the code compile.

Windows only seems to return WSAE* errors, so we need to check for these
errors on Windows.

However the WSAE* error definitions only exist on Windows, they do not
exist on Posix.

Trying to import them causes a failure on Posix.

On Posix, we now just reassign the WSAE* error values to the normal E*
values, letting the code compile.
@rickprice rickprice requested a review from icanhasmath June 26, 2024 20:40
Copy link

@icanhasmath icanhasmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works.

@icanhasmath icanhasmath merged commit 53a880a into 2.7 Jun 26, 2024
@icanhasmath icanhasmath deleted the BE-3962-core-async-fix branch June 26, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants