Be 4504 python 2 7 expat update iiii #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickprice
force-pushed
the
BE-4504-python-2-7-expat-update-IIII
branch
from
271c1a6 to
2c4e5d7
Compare
icanhasmath
reviewed
Dec 17, 2024
icanhasmath
requested changes
Dec 17, 2024
icanhasmath
left a comment
icanhasmath
left a comment
There was a problem hiding this comment.
I want us to insert one commit behind this one.
We need to copy the files for expat in directly - without changing them in the same commit.
That way we can track the modifications - this will make it easier to re-vendor if need-be -- though if we're moving to the other model we should just rip it out.
rickprice
force-pushed
the
BE-4504-python-2-7-expat-update-IIII
branch
from
2c4e5d7 to
6470e2b
Compare
Add #define for XML_GE which exists in the newer version Rename struct "PREFIX" that conflicts, perhaps with MSVC
rickprice
force-pushed
the
BE-4504-python-2-7-expat-update-IIII
branch
from
6470e2b to
1e74097
Compare
Author
Done, IE split commit into two stages. |
icanhasmath
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendored Expat 2.6.4, but more importantly, changed the Visual Studio files for Windows to link against our Platform built Expat.