Be 3659 CVE 2007 4559 iiii #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickprice
force-pushed
the
BE-3659-cve-2007-4559-IIII
branch
from
6cf9854 to
9c778f8
Compare
rickprice
force-pushed
the
BE-3659-cve-2007-4559-IIII
branch
from
9c778f8 to
738cba1
Compare
ucodery
requested changes
Jan 7, 2025
rickprice
force-pushed
the
BE-3659-cve-2007-4559-IIII
branch
4 times, most recently
from
490661d to
a2c11e4
Compare
ucodery
reviewed
Jan 8, 2025
ucodery
left a comment
ucodery
left a comment
There was a problem hiding this comment.
This change will need a News entry. In addition to the CVE fix, the change in TarFile and ExFileObject API should be noted
Lib/test/test_tarfile.py
Outdated
| 0o10000000) | ||
| self.assertEqual(tarfile.nti(b"\x80\x00\x00\x00\xff\xff\xff\xff"), | ||
| 0xffffffff) | ||
| # self.assertEqual(tarfile.nti(b"\xff\xff\xff\xff\xff\xff\xff\xff"), |
There was a problem hiding this comment.
What's the reason for not running all these checks?
Author
There was a problem hiding this comment.
Those are for unsupported header types
rickprice
force-pushed
the
BE-3659-cve-2007-4559-IIII
branch
from
fb8811b to
659de44
Compare
rickprice
force-pushed
the
BE-3659-cve-2007-4559-IIII
branch
from
659de44 to
4801727
Compare
ucodery
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for CVE-2007-4559