Non mandatory tour #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And all the alternatives, model, and all the new columns that are required to support it. Only about halfway through at this point but hopefully gets a bit faster going forward. Also added proper newlines to the csv file so they look ok outside of excel. Also started keeping a todo list in markdown to keep track of anything that will need revisiting before the model is fully usable.
still need to polish one or two things before opening a PR though, but pretty close
for full time worker only at this point
only running for the full time worker person type at this time
…neration 140 lines or so to go!
there are a couple of issues - the window residual and the presence of X type not including chooser other than that this is looking pretty good
I didn't realize all the segments in the non mandatory model had the same spec - this made things much easier (i.e. I didn't have to definite 250 variables for every segment). Anyway this is now running and brings up a few questions which I will add to the readme.md.
bstabler
pushed a commit
that referenced
this pull request
Aug 11, 2020
Fixed auto sufficiency conditions in tour_mode_choice.csv. (Issue #324)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty good draft of the non-mandatory tour generation model
There are two main caveats which are already in the issues on this repo