File reorg #29
Merged
File reorg #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And all the alternatives, model, and all the new columns that are required to support it. Only about halfway through at this point but hopefully gets a bit faster going forward. Also added proper newlines to the csv file so they look ok outside of excel. Also started keeping a todo list in markdown to keep track of anything that will need revisiting before the model is fully usable.
still need to polish one or two things before opening a PR though, but pretty close
for full time worker only at this point
only running for the full time worker person type at this time
…neration 140 lines or so to go!
there are a couple of issues - the window residual and the presence of X type not including chooser other than that this is looking pretty good
I didn't realize all the segments in the non mandatory model had the same spec - this made things much easier (i.e. I didn't have to definite 250 variables for every segment). Anyway this is now running and brings up a few questions which I will add to the readme.md.
a few caveats 1) this has no mode choice logsums 2) it uses fully random sampling 3) it's missing size terms 4) the escort trip type is not split into with and without child ... but basic workflow is completely there - every tour now has a destination
not working yet as far as model specifications and such
need to ask a few questions about the time windowing
no new functionality here - just splitting up the one large file into 8-10 smaller files. Now have a models directory and one file per model, as well as a tables directory and one file per table. Remember this is only a convention, so mixing in other aspects of the simulation framework where appropriate is expected.
might take a couple of tries to get this working with travis
Contributor
Author
|
@jiffyclub Any idea why travis isn't running on this PR? |
Contributor
|
Looks like it's getting started now, dunno why it took a while. |
Contributor
Author
|
So this is failing because there's a dependency on those |
Contributor
|
I don't want to release urbansim just yet because I need to figure out why the sanfran_urbansim test is failing. If you want to install urbansim from master on Travis take it out of the conda installation and add this line at the end of the installation section: |
Contributor
Author
|
Sounds good - that should work. |
Renaming variables and addding TODO markers where appropriate. Also uncovered a bug in the simulation routine. Will need to switch to tested activitysim code soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major file reorganization. This PR subsumes all the previous PRs. Also added tests to this - travis is likely to fail the first couple of times through - we shall see.