[Phase 7] Sharrow -- 1 Zone #579
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it fails later tests
because windows
…black # Conflicts: # activitysim/core/config.py # activitysim/examples/example_manifest.yaml # activitysim/examples/prototype_arc/configs/settings_mp.yaml
for base activitysim
dhensle
requested changes
Sep 1, 2022
Contributor
dhensle
left a comment
dhensle
left a comment
There was a problem hiding this comment.
A majority of the requested changes are around documentation. There's a lot of stuff added in here and I think we need to document well to mitigate any increase into the already steep learning curve of ActivitySim development or usage.
There are a number of comments and areas about the handling of maz level skims that I left under the assumption they will be addressed in the sharrow two and three zone work.
i-am-sijia
reviewed
Sep 13, 2022
Contributor
|
I have not gone through every file yet, especially ones in activitysim/workflows/. Will finish them and add more comments this week. |
i-am-sijia
requested changes
Sep 15, 2022
Member
Author
|
Close in favor of #611 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supercedes #542, and is written with black enabled to simplify code review (relatively)