build: fix to altool check in notarize.sh#1266
build: fix to altool check in notarize.sh#1266ErikBjare merged 2 commits intoActivityWatch:masterfrom
Conversation
修复notarization_method未正确设置的问题,将altool检查逻辑移至else块中
Greptile SummaryThis PR fixes a two-part bug in the notarization tool-detection logic of Confidence Score: 5/5Safe to merge — the logic fix is correct and the only remaining finding is a minor style suggestion on the availability probe. The change is a clean, well-scoped bug fix with no new logic introduced. The single remaining comment is a P2 style suggestion (using No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Start: notarization_method=exit] --> B{xcrun notarytool\navailable?}
B -- Yes --> C[notarization_method=run_notarytool]
B -- No --> D{xcrun altool\navailable?}
D -- Yes --> E[notarization_method=run_altool]
D -- No --> F[notarization_method=exit]
C --> G{method = exit?}
E --> G
F --> G
G -- Yes --> H[echo error & exit]
G -- No --> I{app dir exists?}
I -- Yes --> J[zip & notarize app\nstaple app]
I -- No --> K[skip app]
J --> L{dmg exists?}
K --> L
L -- Yes --> M[notarize dmg\nstaple dmg]
L -- No --> N[skip dmg]
Reviews (1): Last reviewed commit: "fix(scripts): 修复notarize.sh中条件判断逻辑错误" | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
修复notarization_method未正确设置的问题,将altool检查逻辑移至else块中