Extended API with import/export endpoints#42
Merged
Conversation
ghost
assigned
4 tasks
ErikBjare
force-pushed
the
dev/extended-api
branch
from
db8b395 to
6c3fd6e
Compare
|
|
||
| def import_bucket(self, bucket: dict) -> None: | ||
| endpoint = "import" | ||
| self._post(endpoint, {"buckets": {bucket["id"]: bucket}}) |
Member
There was a problem hiding this comment.
Can you add an test for this?
Member
Author
There was a problem hiding this comment.
We don't have extensive tests for the other endpoints, and I'm not going to set that up, so no.
Maybe there is in the aw-server repo? We should put them all in one place somehow so we can do proper integration testing for both aw-server-python and aw-server-rust with a single test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.