chore: Export intended public imports#76
Merged
ErikBjare merged 1 commit intoActivityWatch:masterfrom Sep 4, 2023
Merged
Conversation
It looks like MyPy and Pyright currently require imports like these to be re-exported in order to be used. Doing this raises a lint error for me due to Pyright: ```python import aw_client aw_client.ActivityWatchClient() # "ActivityWatchClient" is not exported from module "aw_client" ``` Ref: https://github.com/microsoft/pyright/blob/main/docs/typed-libraries.md#library-interface Ref: microsoft/pyright#3409 Ref: python/mypy#8754 (comment)
Member
|
Ah, you're right about this. I've learned the same as well since, but not revisited here. Thanks! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like MyPy and Pyright currently require imports like these to be re-exported in order to be used. Doing this raises a lint error for me due to Pyright:
Ref: https://github.com/microsoft/pyright/blob/main/docs/typed-libraries.md#library-interface
Ref: microsoft/pyright#3409
Ref: python/mypy#8754 (comment)
I assume the
noqawas to handle theActivityWatchClientsymbol not being used. My linter doesn't complain about it being unused anymore because it special cases for the__all__elements even though they are strings. I'm guessing you're linter is the same way but it not you'll probably want to remove that edit.