build(deps): fix building with peewee 4#133
build(deps): fix building with peewee 4#133wojnilowicz wants to merge 1 commit intoActivityWatch:masterfrom
Conversation
Greptile SummaryThis PR widens the
Confidence Score: 4/5The pyproject.toml pin change is the functional fix and is correct in intent; the peewee.py change introduces dead code with a misleading comment that should be corrected before merging. There is one P1 finding: the ImportError fallback is dead code (the class it guards against being missing is not actually missing in peewee 4), and the inaccurate comment will mislead future maintainers. The version constraint syntax is a P2 style issue. These lower confidence from 5 to 4. aw_datastore/storages/peewee.py — the try/except import block needs re-examination; pyproject.toml — minor syntax cleanup needed. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Import peewee] --> B{peewee version}
B -- "3.x" --> C[playhouse.sqlite_ext.SqliteExtDatabase exists]
B -- "4.x" --> D[playhouse.sqlite_ext.SqliteExtDatabase\nSTILL exists in peewee 4]
C --> E[try block succeeds]
D --> E
E --> F[SqliteExtDatabase used as-is]
G[except ImportError] --> H[Fallback: peewee.SqliteDatabase\nas SqliteExtDatabase]
G -.->|"Never triggered\nwith peewee 3 or 4"| H
Reviews (1): Last reviewed commit: "build(deps): fix building with peewee 4" | Re-trigger Greptile |
9a6614b to
40508b9
Compare
No description provided.