fix: If events merge during flood, choose the longest endtime#143
Merged
johan-bjareholt merged 3 commits intomasterfrom Jul 5, 2020
Merged
fix: If events merge during flood, choose the longest endtime#143johan-bjareholt merged 3 commits intomasterfrom
johan-bjareholt merged 3 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
- Coverage 43.90% 43.33% -0.58%
==========================================
Files 48 48
Lines 5687 7463 +1776
Branches 1456 2331 +875
==========================================
+ Hits 2497 3234 +737
- Misses 2457 3166 +709
- Partials 733 1063 +330
Continue to review full report at Codecov.
|
ErikBjare
approved these changes
Jul 4, 2020
johan-bjareholt
force-pushed
the
dev/flood-merge-same-timestamp
branch
from
690665e to
e0a3e57
Compare
johan-bjareholt
force-pushed
the
dev/flood-merge-same-timestamp
branch
from
e0a3e57 to
5b7467f
Compare
johan-bjareholt
force-pushed
the
dev/flood-merge-same-timestamp
branch
from
4e44dd5 to
773f2f9
Compare
johan-bjareholt
force-pushed
the
dev/flood-merge-same-timestamp
branch
from
3f12ecd to
a968be4
Compare
ErikBjare
reviewed
Jul 6, 2020
| retry_e = Some(e1); | ||
| // Since we are retrying on this event we don't want to push it | ||
| // to the new_events vec | ||
| continue; |
Member
There was a problem hiding this comment.
Cool! Took me a while to understand what's going on with retry_e, but looks performant 😃
Member
Author
There was a problem hiding this comment.
It's mostly to make the borrow checker happy, there are more readable ways to implement it if you write "unsafe" code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140