Skip to content

Added x86_64 build target on android#50

Merged
ErikBjare merged 1 commit intomasterfrom
dev/android-x86-64bit
May 24, 2019
Merged

Added x86_64 build target on android#50
ErikBjare merged 1 commit intomasterfrom
dev/android-x86-64bit

Conversation

@ErikBjare
Copy link
Copy Markdown
Member

First step towards fixing ActivityWatch/aw-android#20

@ErikBjare ErikBjare merged commit f8b35ab into master May 24, 2019
@ErikBjare ErikBjare deleted the dev/android-x86-64bit branch May 24, 2019 18:55
Comment thread compile-android.sh
# Ring won't build in the below target for whatever reason
# 'arm armv7-linux-androideabi' \
for archtargetstr in \
'x86 i686-linux-android' \
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove 32-bit support completely, it just slows down testing time. I have a 10 year old laptop and even that has a 64-bit CPU. The Core 2 series were the first mainstream 64-bit Intel CPUs and they have been available for 13 years now!

Copy link
Copy Markdown
Member Author

@ErikBjare ErikBjare May 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why, but Google seems to suggest supporting 32-bit x86 is normal: https://developer.android.com/distribute/best-practices/develop/64-bit

Could check the device support matrix and see if there actually are any 32-bit x86 devices out there that don't support x86_64, but until then I'll keep it.

It's annoying with the build times, but I'd rather we make it such that we don't build for every target on non-release builds.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be because of those mobile Intel mobile SoC for smartphones which Intel made one generation of and failed spectacularly in 2014, they were 32-bit. Since then they probably just want x86_64 APKs because of Chromebooks now supporting Android apps.

Comment thread .cargo/config
@@ -9,3 +9,7 @@ linker = './NDK/arm/bin/arm-linux-androideabi-clang'
[target.i686-linux-android]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants