datastore: refactoring of relationship between worker and instance#65
Merged
johan-bjareholt merged 1 commit intomasterfrom Sep 20, 2019
Merged
datastore: refactoring of relationship between worker and instance#65johan-bjareholt merged 1 commit intomasterfrom
johan-bjareholt merged 1 commit intomasterfrom
Conversation
Member
johan-bjareholt
commented
Sep 14, 2019
johan-bjareholt
commented
- Split worker code out into a seperate module
- instance should now be easy to use without the worker
- Moved commit and uncommited_events out of DatastoreInstance
Merged
ErikBjare
approved these changes
Sep 20, 2019
Member
ErikBjare
left a comment
ErikBjare
left a comment
There was a problem hiding this comment.
Hard to compare the diffs, but assuming it's mostly copy/paste I'm fine with this.
- Split worker code out into a seperate module - instance should now be easy to use without the worker - Moved commit and uncommited_events out of DatastoreInstance
johan-bjareholt
force-pushed
the
dev/datastore-refactoring
branch
from
cca9294 to
14be598
Compare
This was referenced Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.