chore: add prettier and format project#100
Closed
mafredri wants to merge 1 commit intoActivityWatch:masterfrom
Closed
chore: add prettier and format project#100mafredri wants to merge 1 commit intoActivityWatch:masterfrom
mafredri wants to merge 1 commit intoActivityWatch:masterfrom
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
prettieras a dev-dependency and slightly adjusts its default settings so that project-wide changes are minimal.prettiermake formatcommand.editorconfigfrom 4 to 2 spaces which best matches existing formattingjsonto editorconfig and format all json files with 2 spaces (to matchmanifest.json)Why this I make this PR?
I started to make some changes (with the goal of building for Safari), but the inconsisten formatting/style kind of got in my way 😅.
Hope you can consider this, and I'm open to changing any settings you don't agree with. (PS. I suggest reviewing without whitespace changes.)