fix: fixed incorrectly referenced ts module in new settings popup#155
Merged
ErikBjare merged 1 commit intoActivityWatch:masterfrom Feb 11, 2025
Merged
fix: fixed incorrectly referenced ts module in new settings popup#155ErikBjare merged 1 commit intoActivityWatch:masterfrom
ErikBjare merged 1 commit intoActivityWatch:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 555e0a9 in 56 seconds
More details
- Looked at
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. src/settings/index.html:40
- Draft comment:
Referencing a TypeScript file directly is unusual since browsers don't natively support TS. Ensure your build process transpiles main.ts to JS for deployment. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
While browsers don't natively run .ts files, modern build setups often use tools like Vite that can handle TypeScript files directly in development. The type="module" attribute suggests this is a modern setup. Without seeing the build configuration, we can't assume this is incorrect.
I might be making assumptions about the build setup. The comment could be raising a valid concern about production deployment.
However, the comment violates our rules - it's asking to "ensure" something about the build process, which is both speculative and outside the scope of this file review.
Delete the comment as it's speculative, asks for verification, and requires knowledge of the build setup that we don't have.
2. src/settings/index.html:40
- Draft comment:
Referencing a .ts file directly in the script tag may cause runtime errors. Typically, the build process should output a compiled .js file, which the HTML should then load. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_Ddyqrlf2G2AItaPU
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Contributor
|
I also had this problem in #156, but with firefox. |
Infiniti151
pushed a commit
to Infiniti151/aw-watcher-web
that referenced
this pull request
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the popup wasn't working after I cloned, built and installed the extension afresh after #154 - settings/main.ts wasn't being built when using
make build-chrome.Important
Fixes script loading issue in
index.htmlby changing source frommain.jstomain.ts.settings/main.tswas not being built when usingmake build-chrome.index.htmlfrommain.jstomain.tsto ensure correct module loading.This description was created by
for 555e0a9. It will automatically update as commits are pushed.