Conversation
| labels.append("appname:" + current_window["appname"]) | ||
| current_window_event = Event(label=labels, timestamp=now) | ||
|
|
||
| client.heartbeat(bucketname, current_window_event, 2*args.poll_time) |
Member
There was a problem hiding this comment.
The default poll time is 1.0, what does that mean? A second? A minute?
And why 2*poll_time?
Member
Author
There was a problem hiding this comment.
One second. The 2*poll_time is there since the loop block obviously takes more than poll_timeseconds (we know it takes at least that long due to the sleep(poll_time)).
A better value would probably be poll_time + 1, I'll fix that tomorrow.
Member
There was a problem hiding this comment.
isn't 1 second a little too low as the default value?
vasuemme111
pushed a commit
to Ralvie-AI/aw-watcher-window
that referenced
this pull request
Apr 24, 2024
Fix the issue where the application name are same for some system applications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on the following PRs