Combine and display chrome + firefox data in Browser Section#108
Combine and display chrome + firefox data in Browser Section#108nicolae-stroncea wants to merge 6 commits intoActivityWatch:masterfrom nicolae-stroncea:allBrowserDatanoArrows
Conversation
johan-bjareholt
left a comment
There was a problem hiding this comment.
Nice!
I was a bit sceptical about this at first due being unsure where we are supposed to use "flood" and not in this case. After thinking a bit about it this seems to be correct, to flood the browser buckets but not the window events after filtering by app.
I have not looked at the rest of the code nor tested it, only looked at the new query.
Thoughts @ErikBjare?
|
@johan-bjareholt The best way to figure out if you've done flooding right is to simply inspect the events in the source buckets and the final events used in the query result (I'd suggest using the new timeline). But I think this is the right way to go, flooding should generally be done as early as possible. |
|
I tested both approaches initially. Flooding the window events led to the durations being too large, which I assume is due to both browser events intersecting with the same timestamps from the window watcher. Doing it separately ends up with the correct intersections. |
|
@nicolae-stroncea Alright, just fix the issues in ActivityWatch/aw-core#70 and we'll merge this. |
|
Also, it looks like you did something weird with |
|
Oh, I forgot about this PR completely. Fix the conflict and we'll merge this directly. |
|
I've fixed the issues and cleaned up stuff in #141. Closing this one, thanks for the amazing work @nicolae-stroncea! (and sorry for the delay) |
Depends on ActivityWatch/aw-core#70