bugfix: Inconsistency when changing period length#193
Merged
johan-bjareholt merged 1 commit intomasterfrom Apr 28, 2020
Merged
Conversation
johan-bjareholt
commented
Apr 27, 2020
| div.p-1(v-if="periodLength === 'day'") | ||
| input.form-control(id="date" type="date" :value="date" :max="today" | ||
| @change="setDate($event.target.value)") | ||
| @change="setDate($event.target.value, periodLength)") |
Member
Author
There was a problem hiding this comment.
This was the real dealbreaker, we were not passing the periodLength to this function here.
Member
|
I made the same fix in #183 before you opened this PR. |
Member
Author
@ErikBjare That's not enough, in the setDate function you are still using this.periodLengthMoment which is still the previos periodLength. I'm merging this, the conflict should be easy to solve (or maybe git can even resolve it automatically). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ActivityWatch/activitywatch#407