Skip to content

Allow horizontal scrolling (e.g. with touchpad) in timeline#237

Open
NicoWeio wants to merge 1 commit intoActivityWatch:masterfrom
NicoWeio:timeline-horizontal-scroll
Open

Allow horizontal scrolling (e.g. with touchpad) in timeline#237
NicoWeio wants to merge 1 commit intoActivityWatch:masterfrom
NicoWeio:timeline-horizontal-scroll

Conversation

@NicoWeio
Copy link
Contributor

@NicoWeio NicoWeio commented Dec 1, 2020

I didn't get node-sass to run on my Manjaro machine, so I'll (ab)use your CI for this small change. :)
Update: Oops, no build artifact. Gonna try something else…

@ErikBjare
Copy link
Member

ErikBjare commented Dec 1, 2020

Did you try 'npm rebuild node-sass' (or whatever other recommendation is spit out when building node-sass fails)? If so, you'll probably have to use nvm or similar to get a lower node version.

It's a pretty common issue: https://stackoverflow.com/questions/53125291/build-fails-npm-rebuild-node-sass-force

node-sass is actually deprecated, and I've wanted to make the switch to dart-sass, which I assume doesn't have these annoying build issues.

@NicoWeio
Copy link
Contributor Author

NicoWeio commented Dec 1, 2020

Wow, that indeed worked. No idea why I didn't find that solution while doing my googling. Thanks!

Regarding horizontal scrolling, though: I managed to get it to work by setting horizontalScroll: true, but I could not find any configuration that would allow to both zoom (on scrolling vertically/normally) and scroll horizontally (= no UX change for those without mice/touchpads that allow for horizontal scrolling). I opened an issue for this, but maybe the configuration of my current prototype is better anyway: It scrolls horizontally for both input scroll directions, and allows zooming by using the Ctrl modifier. Vertical scrolling would also be possible.
The latter would mean a UX change for all users, though, so I am curious to hear what you think about that, given that you're working on a complete overhaul of the timeline anyway.

Example without vertical scrolling
Example with vertical scrolling (bottom)

@ErikBjare
Copy link
Member

ErikBjare commented Dec 2, 2020

Ah, that makes things a bit more difficult. I'm not sure the UX change is for the better, I don't really like the idea of requiring a modifier key to zoom, but I guess it's an option.

Nice that you opened an issue, I'll keep an eye on it.

given that you're working on a complete overhaul of the timeline anyway.

Not really working, more like planning 🙂

@ErikBjare
Copy link
Member

Update: Oops, no build artifact. Gonna try something else…

Just a heads up, I added uploading of the build artifact in ba2374b 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants