Skip to content

Add Arc browser data in Timeline > Browser tab#622

Closed
cktang88 wants to merge 1 commit intoActivityWatch:masterfrom
cktang88:master
Closed

Add Arc browser data in Timeline > Browser tab#622
cktang88 wants to merge 1 commit intoActivityWatch:masterfrom
cktang88:master

Conversation

@cktang88
Copy link
Copy Markdown

@cktang88 cktang88 commented Jan 3, 2025

Currently /activity/Mac/view/browser will not display Arc browser data, despite that data already appearing in the /#/timeline tab. This fixes the issue.

We fix this by just pushing all the Arc browser data to the chrome bucket for purposes of visualization. While not a perfect solution, it is an easy one, and far superior to not displaying that data at all.

This issue is known:

fixes ActivityWatch/activitywatch#1094

This fix can be extended to support Brave/Vivaldi/etc, without relying on custom browser identification hacks. The tradeoff (obviously) is that all browsers' data based on chromium gets merged I guess.

@ErikBjare if you have time would love a quick look :)


Important

Fixes Arc browser data display issue by associating it with Chrome's bucket in queries.ts.

  • Behavior:
    • Fixes issue where Arc browser data was not displayed in /activity/Mac/view/browser by associating Arc with Chrome's bucket in browsersWithBuckets() in queries.ts.
  • Misc:
    • Adds Arc browser to browser_appnames in queries.ts.

This description was created by Ellipsis for ef85adc. It will automatically update as commits are pushed.

Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ef85adc in 14 seconds

More details
  • Looked at 21 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/queries.ts:292
  • Draft comment:
    The logic for finding the Chrome bucket for Arc browser can be simplified by directly checking for 'arc' in the bucket_id. This avoids the need for a separate chrome_bucket variable.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code correctly identifies Arc browser using Chrome's bucket, but the logic can be simplified.

Workflow ID: wflow_fNKmp6MsmTN5RjyK


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@BelKed
Copy link
Copy Markdown
Contributor

BelKed commented Jan 7, 2025

Nice workaround, but it has potential problems if the user is using both Chrome and Arc. A better approach would be for the user to select their web browser in the web watcher if their browser isn't one of the mainstream/easily detectable ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Top Browser Domains/URLs - No data on Arc

2 participants