Remove non-ascii characters from setup config#2
Merged
ahcorde merged 1 commit intoAcutronicRobotics:ros2from Jul 19, 2019
nzlz:ros2
Merged
Remove non-ascii characters from setup config#2ahcorde merged 1 commit intoAcutronicRobotics:ros2from nzlz:ros2
ahcorde merged 1 commit intoAcutronicRobotics:ros2from
nzlz:ros2
Conversation
LanderU
approved these changes
Jul 19, 2019
ahcorde
approved these changes
Jul 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using non-ascii in the setup file requires the building system to handle UTF language options (e.g. we have to take this into account in our Docker images too).
Simply removing this characters solves this issue. I'm using Qt-Creator and did not find any other workaround. https://gist.github.com/nzlz/fbcca29a572ea2a3f5ce762a612fb65e