Indicators not visible

[johnallen3d]

I've pulled the latest version (after #18) and I'm no longer seeing the indicators (with or without icons). I've tried deleting and re-cloning the repo, restarting yabai and Hammerspoon. I've also removed the yabai signals that were previously required. I'm sure I'm missing something but I can't put my finger on it. 🤔

❯ cat init.lua
local stackline = require "stackline.stackline.stackline"
❯ which hs
/usr/local/bin/hs

Hamerspoon console logs:

2020-08-22 22:36:44: Welcome to the Hammerspoon Console!
You can run any Lua code in here.

2020-08-22 22:36:44: -- Lazy extension loading enabled
2020-08-22 22:36:44: -- Loading ~/.hammerspoon/init.lua
2020-08-22 22:36:44: -- Loading extension: settings
2020-08-22 22:36:44: org.hammerspoon.Hammerspoon
2020-08-22 22:36:44: -- Loading extension: ipc
2020-08-22 22:36:44: -- Loading extension: fnutils
2020-08-22 22:36:44: -- Loading extension: window
2020-08-22 22:36:44: -- Loading extension: uielement
2020-08-22 22:36:44: -- Loading extensions: window.filter
2020-08-22 22:36:45: -- Loading extension: timer
2020-08-22 22:36:45: -- Loading extension: spaces
2020-08-22 22:36:45: -- Loading extension: task
2020-08-22 22:36:45: -- Done.
2020-08-22 22:36:45: -- Loading extension: json
2020-08-22 22:36:49: 22:36:49 ** Warning:   wfilter: No accessibility access to app zoom.us (no watcher pid)
2020-08-22 22:36:50: 22:36:50 ** Warning:   wfilter: No accessibility access to app Ferdi Helper (Renderer) (no watcher pid)
2020-08-22 22:36:50: 22:36:50 ** Warning:   wfilter: No accessibility access to app Messages Networking (no watcher pid)
2020-08-22 22:36:50: 22:36:50 ** Warning:   wfilter: No accessibility access to app FirefoxCP WebExtensions (no watcher pid)
2020-08-22 22:36:50: 22:36:50 ** Warning:   wfilter: No accessibility access to app FirefoxCP Web Content (no watcher pid)
2020-08-22 22:36:50: 22:36:50 ** Warning:   wfilter: No accessibility access to app FirefoxCP RDD Process (no watcher pid)
2020-08-22 22:36:50: 22:36:50 ** Warning:   wfilter: No accessibility access to app FirefoxCP Privileged Content (no watcher pid)

[AdamWagner]

I've tried deleting and re-cloning the repo, restarting yabai and Hammerspoon. I've also removed the yabai signals that were previously required. I'm sure I'm missing something but I can't put my finger on it.

Hmm, that's the full set of things that I can imagine making a difference.

I've been working on the documentation most of the day, and have made a ton of commits in the process. It's possible that something I did affected master. I'll go through the process locally & see if I can find it.

[johnallen3d]

Thanks for checking @AdamWagner! If there are any other details I could provide please let me know.

[AdamWagner]

@johnallen3d Ok, I found a problem, but I'm not sure that it's the problem:

e044ef7

…I messed up the shell path again, and fixed it again. I've typed /usr/local/bin/dash so many times, it's habit.

Assuming this does not fix the issue, could you share:

1. the list of apps that are stacked (for which you expect to see indicators)
2. the output from:

~/.hammerspoon/stackline/bin/yabai-get-stack-idx

Another possibility, query.lua, line 8:

local scriptPath = hs.configdir .. '/stackline/bin/yabai-get-stack-idx'

AFAIK, hs.configdir is defined by hammerspoon and requires no special setup by the user. Could you confirm that entering hs.configdir into the hammerspoon console prints out the path to your config directory?

---

As all of these Qs imply, I think the problem is in query.lua. Stackline appears to be running fine… except it never finds any stacked windows to decorate. This could happen if the yabai-get-stack-idx script isn't correctly run, or its response isn't returned as expected.

[AdamWagner]

Depending on what happens there ↑ we can just keep going on down the line ;-)

Next thing to check will be the stackmanager itself.

Again in the hammerspoon console:

hs.inspect(Sm:get()) -- should print big 'ol table. If it prints '{}', then we found the problem

[johnallen3d]

OK, I pulled latest and am still in the same boat.

1. I'm stacking kitty windows (have also tried with Firefox)

2. Output from

   ❯ ~/.hammerspoon/stackline/bin/yabai-get-stack-idx
   {"3942":0,"3941":0,"855":1,"3527":2}

3. Seems like hs.configdir is correct:

   2020-08-22 23:22:47: num stacks changed
   > hs.configdir
   /Users/johna/.hammerspoon

4. stackmanager output (edit: console window wasn't stacked)

   > hs.inspect(Sm:get()) 
   2020-08-22 23:26:01: -- Loading extension: inspect
   {}

[johnallen3d]

Just stacked the Hammerspoon console with Firefox and get this output from stackmanager:

> hs.inspect(Sm:get())
{ <1>{
    id = "1472|-201|2496|1362",
    windows = { {
        _win = <userdata 1> -- hs.window: Hammerspoon Console (0x600003bafec8),
        app = "Hammerspoon",
        canvas_frame = { -- hs.geometry.rect(1440.0,-247.0,2560.0,1440.0)
          _h = 1440.0,
          _w = 2560.0,
          _x = 1440.0,
          _y = -247.0
        },
        config = {
          alpha = 1,
          color = {
            alpha = 1,
            white = 0.9
          },
          dimmer = 2.5,
          fadeDuration = 0.2,
          iconDimmer = 1.1,
          iconPadding = 4,
          offset = {
            x = 4,
            y = 2
          },
          padding = 4,
          pillThinness = 6,
          radius = 3,
          shouldFade = true,
          size = 32,
          vertSpacing = 1.2
        },
        focus = true,
        frame = { -- hs.geometry.rect(1472.0,-201.0,2496.0,1362.0)
          _h = 1362.0,
          _w = 2496.0,
          _x = 1472.0,
          _y = -201.0
        },
        iconIdx = 2,
        iconRadius = 10.666666666667,
        icon_rect = {
          h = 24,
          w = 24,
          x = 2532.0,
          y = -195.0
        },
        id = 3924,
        indicator = <userdata 2> -- hs.canvas: {{1440, -247}, {2560, 1440}} (0x600003af8928),
        indicator_rect = {
          h = 32,
          w = 32,
          x = 2528.0,
          y = -199.0
        },
        otherAppWindows = {},
        rectIdx = 1,
        showIcons = true,
        side = "right",
        stack = <table 1>,
        stackFocus = true,
        stackId = "1472|-201|2496|1362",
        stackIdx = 1,
        title = "Hammerspoon Console",
        topLeft = "1472|-201",
        width = 32
      }, {
        _win = <userdata 3> -- hs.window: Indicators not visible · Issue #27 · AdamWagner/stackline (0x600003b66e48),
        app = "Firefox",
        canvas_frame = { -- hs.geometry.rect(1440.0,-247.0,2560.0,1440.0)
          _h = 1440.0,
          _w = 2560.0,
          _x = 1440.0,
          _y = -247.0
        },
        config = {
          alpha = 1,
          color = {
            alpha = 1,
            white = 0.9
          },
          dimmer = 2.5,
          fadeDuration = 0.2,
          iconDimmer = 1.1,
          iconPadding = 4,
          offset = {
            x = 4,
            y = 2
          },
          padding = 4,
          pillThinness = 6,
          radius = 3,
          shouldFade = true,
          size = 32,
          vertSpacing = 1.2
        },
        focus = false,
        frame = { -- hs.geometry.rect(1472.0,-201.0,2496.0,1362.0)
          _h = 1362.0,
          _w = 2496.0,
          _x = 1472.0,
          _y = -201.0
        },
        iconIdx = 2,
        iconRadius = 10.666666666667,
        icon_rect = {
          h = 24,
          w = 24,
          x = 2532.0,
          y = -156.6
        },
        id = 2454,
        indicator = <userdata 4> -- hs.canvas: {{1440, -247}, {2560, 1440}} (0x600003af70e8),
        indicator_rect = {
          h = 32,
          w = 32,
          x = 2528.0,
          y = -160.6
        },
        otherAppWindows = {},
        rectIdx = 1,
        showIcons = true,
        side = "right",
        stack = <table 1>,
        stackFocus = true,
        stackId = "1472|-201|2496|1362",
        stackIdx = 2,
        title = "Indicators not visible · Issue #27 · AdamWagner/stackline",
        topLeft = "1472|-201",
        width = 32
      } }
  } }

[AdamWagner]

Thanks @johnallen3d – that's super helpful.

Problem No. 1: window frame y coordinate is way off-screen

I see the critical issue that's preventing indicators from appearing even when a stack is detected:

canvas_frame = { -- hs.geometry.rect(1440.0,-247.0,2560.0,1440.0)
  _h = 1440.0,
  _w = 2560.0,
  _x = 1440.0,
  _y = -247.0  ←←←←←← this is off screen!
}

Do you happen to use multiple monitors? If so, this is a known unknown: #22

I'll definitely work on multi-monitor support next if that's preventing this from working for ya.

Problem No. 2: Stacked kitty widows aren't being detected (??)

hs.inspect(Sm:get())
2020-08-22 23:26:01: -- Loading extension: inspect
{}

This one is more puzzling. I also use kitty and have never had issues with stack detection. Kitty in particular should be pretty foolproof to stack detection issues due to it's small minimum size constraint (stackline requires that window frames overlap exactly to be considered "stacked").

And, I apologize that this isn't that helpful, but I can confirm that Firefox is stacking here as expected:

[johnallen3d]

Thanks for the rapid responses @AdamWagner. You nailed it, I do use multiple monitors! I saw #22 earlier and just didn't put 2 and 2 together, my bad! (🤦)

As for stacked kitty windows. I suspect at the moment I ran hs.inspect(Sm:get()) the first time I had unstacked my kitty windows and that that is a red-herring.

I'll close this issue and track #22. Thanks again for the help and the great project!

[johnallen3d]

Just to be sure I unplugged my external and... 🎉

Also works just fine on my primary screen (laptop display) while external is plugged in.

[AdamWagner]

@johnallen3d Thank you for testing & all the debug info. Seriously.

Stackline definitely still has a ways to go before it will generally work for most people in most cases, so real-world trial & error like this is super important.

For example, I learned something just from your last screenshot: we definitely need to make it super easy to customize the x-axis padding between the indicator and the window edge… I hadn't considered border thickness as a factor before. It would be even better if we could read the window_border_width from yabai, but I don't think that's possible.

[AdamWagner]

@johnallen3d I found a shortcut for minimally-viable multi-monitor support. It's live on https://github.com/AdamWagner/stackline/tree/feature/multi-monitor now if you'd like to try it out.

The major shortcoming that I'd like to fix is that stack indicators are only rendered on the monitor containing the focused window. If you have stacks on other monitors, indicators for those stacks will not display until that monitor is focused.

[AdamWagner]

@johnallen3d actually, just kidding ;-)

Found a way to get stack indicators to render on all screens. I'm hopeful that https://github.com/AdamWagner/stackline/tree/feature/multi-monitor will work rather well for you, now!