Skip to content

Fix/nil windows in get summary #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdamWagner merged 2 commits into from
Dec 12, 2020
Merged

Fix/nil windows in get summary #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54034dd
Guard against re-initialization of stackline.
AdamWagner Nov 28, 2020
a50a458
Guard against nil indicator in Stack:getWindowByPoint()
AdamWagner Nov 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions stackline/stack.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ end -- }}}

function Stack:getWindowByPoint(point) -- {{{
local foundWin = u.filter(self.windows, function(w)
if not w.indicator then return false end
local indicatorEls = w.indicator:canvasElements()
local wFrame = hs.geometry.rect(indicatorEls[1].frame)
return point:inside(wFrame)
Expand Down
5 changes: 5 additions & 0 deletions stackline/stackline.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ stackline.window = require 'stackline.stackline.window'
function stackline:init(userConfig) -- {{{
log.i('starting stackline')

if stackline.manager then
-- guard against re-initializtion https://github.com/AdamWagner/stackline/issues/46#issuecomment-723527826
return print('stackline already initialized')
end

-- Default window filter controls what windows hs "sees"
-- Required before initialization
self.wf = wf.new():setOverrideFilter{ -- {{{
Expand Down