Skip to content

Shaokai/multi video #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MMathisLab merged 36 commits into from
Jul 28, 2024
Merged

Shaokai/multi video #39

MMathisLab merged 36 commits into from
Jul 28, 2024

Conversation

@yeshaokai
Copy link
Collaborator

@yeshaokai yeshaokai commented Jul 23, 2024 •
edited
Loading

Change log

  1. By default to use gpt-4o-mini, so it's now much cheaper
  2. Supporting single-query-multiple-videos
  3. Changing the input of low level classes to take behavior identifier (combination of config, keypoint file path and video file path) instead of config alone
  4. Refactoring QA_Message
  5. Refactoring the output representation to be a dictionary to encode multiple video paths
  6. Some other improvements
  7. Added tests
  8. Updated demo notebooks

@yeshaokai yeshaokai requested a review from MMathisLab July 23, 2024 15:06
yeshaokai added 20 commits July 23, 2024 18:55
@yeshaokai yeshaokai self-assigned this Jul 28, 2024
@MMathisLab MMathisLab added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 28, 2024
@MMathisLab
Delete INSTALL.md
58d2be3 
- this is redundant with information in main docs now
@MMathisLab
Update README.md
edc773a
MMathisLab
MMathisLab approved these changes Jul 28, 2024
View reviewed changes
Copy link
Member

@MMathisLab MMathisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a lot for 1 PR, so I did not check all demo notebooks yet, but can be addressed in other PRs ...

@MMathisLab
Update and rename amadesuGPT-cpu.yml to amadesuGPT.yml (#40)
20fa3d6 
* Update and rename amadesuGPT-cpu.yml to amadesuGPT.yml

* Delete conda/amadesuGPT-gpu.yml

* Delete conda/amadesuGPT-minimal.yml

* Update amadesuGPT.yml

- amadeusgpt should be a dependency
@MMathisLab MMathisLab merged commit 8082ee2 into main Jul 28, 2024
@MMathisLab MMathisLab deleted the shaokai/multi_video branch July 28, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MMathisLab MMathisLab MMathisLab approved these changes

Assignees

@yeshaokai yeshaokai

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yeshaokai @MMathisLab