Skip to content

Conversation

@yeshaokai
Copy link
Collaborator

Fixed a bug

Changed hardcoded paths to relative paths in demo notebooks

@yeshaokai yeshaokai requested a review from MMathisLab August 8, 2024 13:12
@MMathisLab
Copy link
Member

MMathisLab commented Aug 8, 2024

I guess once residents report more bugs, I can do one more commit push tomorrow and then we can merge.

README.md Outdated

```bash
conda env create -f amadeusGPT.yml
conda env create -f conda/amadeusGPT.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please drop conda; that is not useful is one downloads the file, for example.

Copy link
Collaborator Author

@yeshaokai yeshaokai Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why it keeps coming back actually... I remember I had it removed too. Though Marc told me he was confused why conda/ was not there

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, if one is within the conda/ folder this cannot be run either, so it's best to keep it not there and use that Q as an opportunity to educate :D

@yeshaokai
Copy link
Collaborator Author

@MMathisLab Some improvements based on how residents used it. This can be 0.1.3.

@MMathisLab MMathisLab changed the title Shaokai/0.1.2 patch Shaokai/0.1.3 Aug 12, 2024
@MMathisLab MMathisLab self-requested a review August 12, 2024 13:45
@MMathisLab MMathisLab merged commit cf27b78 into main Aug 12, 2024
@MMathisLab MMathisLab deleted the shaokai/0.1.2_patch branch August 12, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants