Skip to content

Conversation

@MMathisLab
Copy link
Member

@MMathisLab MMathisLab commented Dec 7, 2023

  • updated the name of env to match file name
  • removed constraint on python version and removed nb_conda; tested on m2 mac

@cla-bot cla-bot bot added the CLA signed label Dec 7, 2023
@MMathisLab MMathisLab requested a review from stes December 7, 2023 18:09
remove constraint on python
remove nb_conda
@MMathisLab MMathisLab changed the title Update cebra_paper_m1.yml Update cebra_paper_m1.yml and cebra.yml Dec 7, 2023
Copy link
Member

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, so I played around with some checks. Python 3.12 does not work due to pytorch (https://github.com/pytorch/pytorch/blob/main/RELEASE.md#release-compatibility-matrix) which only supports up to 3.11 right now.

I assume that the conda environment solver is able to see this because "pytorch" is a dependency, so it is fine to remove the constraint.

If we wanted to be more explicit, we could update the constraint to python<=3.11, both fine for me.

@MMathisLab MMathisLab merged commit e36eea5 into main Dec 7, 2023
@stes stes deleted the MMathisLab-conda-name branch December 7, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants