Add OS indepdent paths for monkey, hippocampus and synthetic data #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stes
force-pushed
the
rodrigo/fix-monkey-synth-hippo-path-for-windows-squashed
branch
from
5783d12 to
7c7066f
Compare
stes
force-pushed
the
rodrigo/fix-monkey-synth-hippo-path-for-windows-squashed
branch
from
7c7066f to
d7d89ad
Compare
MMathisLab
reviewed
Aug 24, 2024
| def test_allen(): | ||
| from cebra.datasets import allen | ||
|
|
||
| pytest.skip("Test takes too long") |
MMathisLab
approved these changes
Aug 24, 2024
Member
MMathisLab
left a comment
MMathisLab
left a comment
There was a problem hiding this comment.
lgtm, did not test on Windows (don't have access); one Q on test skip!
stes
deleted the
rodrigo/fix-monkey-synth-hippo-path-for-windows-squashed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch all paths, especially in
cebra.datasets, topathlibfor compatibility across operating systems.Originally added by @gonlairo , this PR is a squashed variant of:
(Needs more tests)