Skip to content

Update build.yml --> python 3.12 #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MMathisLab wants to merge 7 commits into from
Closed

Update build.yml --> python 3.12 #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a38db9c
Update build.yml
MMathisLab Aug 23, 2024
2ae8499
Update setup.cfg
MMathisLab Aug 23, 2024
8108d64
Update build.yml
MMathisLab Aug 23, 2024
5871085
Update build.yml
MMathisLab Aug 23, 2024
2446abe
Update setup.cfg
MMathisLab Aug 23, 2024
13f0e3b
Update build.yml
MMathisLab Aug 23, 2024
75d8c05
Update build.yml
MMathisLab Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,18 @@ jobs:
fail-fast: true
matrix:
os: [ubuntu-latest]
python-version: ["3.8", "3.10"]
python-version: ["3.10", "3.12"]
# We aim to support the versions on pytorch.org
# as well as selected previous versions on
# https://pytorch.org/get-started/previous-versions/
torch-version: ["1.12.1", "2.0.0"]
torch-version: ["2.4.0"]
include:
- os: ubuntu-latest
python-version: 3.8
torch-version: 1.9.0
- os: windows-latest
torch-version: 2.0.0
python-version: "3.10"
torch-version: 2.4.0
python-version: "3.12"
- os: ubuntu-latest
torch-version: 2.1.1
python-version: "3.11"
torch-version: 2.4.0
python-version: "3.12"
#- os: macos-latest
# torch-version: 2.0.0
# python-version: "3.10"
Expand Down
4 changes: 2 additions & 2 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ packages = find:
where =
- .
- tests
python_requires = >=3.8
python_requires = >=3.10
Copy link
Member

@stes stes Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python_requires = >=3.10
python_requires = >=3.9

I would opt to include 3.9, as it will be supported almost till end of 2025 --- I think it has little downside, and enables people with older conda/docker setups to install cebra without additional changes/work.

Thoughts?

install_requires =
joblib
literate-dataclasses
scikit-learn
scikit-learn<=1.4.2
scipy
torch
tqdm
Expand Down