Skip to content

Conversation

@icarosadero
Copy link
Contributor

@icarosadero icarosadero commented Oct 16, 2024

Should fix #174

@cla-bot
Copy link

cla-bot bot commented Oct 16, 2024

Thank you for your contribution. We require contributors to sign our Contributor License Agreement (CLA). We do not have a signed CLA on file for you. In order for us to review and merge your code, please sign our CLA here. After you signed, you can comment on this PR with @cla-bot check to trigger another check.

@icarosadero
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the CLA signed label Oct 16, 2024
@cla-bot
Copy link

cla-bot bot commented Oct 16, 2024

Thanks for tagging me. I looked for a signed form under your signature again, and updated the status on this PR. If the check was successful, no further action is needed. If the check was unsuccessful, please see the instructions in my first comment.

Copy link
Member

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@icarosadero i think the offset here is actually not used, right? We could also consider deprecating the argument instead.

Do you have a code example that's fixed by this change?

Copy link
Member

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update: the original PR description didnt link the correct issue, i see that #174 is actually a problem and this is the correct fix

@stes
Copy link
Member

stes commented Oct 26, 2024

can be merged once tests pass

Copy link
Member

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@icarosadero if you get the chance, could you add a test that reproduces this error #174 (comment) to this PR?

@stes stes added the 🐞 fix label Oct 26, 2024
Copy link
Member

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @icarosadero , lgtm!

@stes stes merged commit 51f048d into AdaptiveMotorControlLab:main Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TensorDataset.offset is set to an int but Dataset.offset is set to an Offset

3 participants