Add Matplotlib ImportError when using compare_models() #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added note to explain this is min.
stes
force-pushed
the
add-matplotlib-error
branch
from
421a104 to
d792f24
Compare
stes
approved these changes
Jul 31, 2023
Member
stes
left a comment
stes
left a comment
There was a problem hiding this comment.
lgtm, as discussed in dev
will merge once tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a custom decorator
@requires_package_versionenabling the specification of the required package version for a specific function. We use it to specify the version ofcompare_models()function since it requires Matplotlib version 3.6 or higher.Fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/pull/639
Fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/issues/580