-
Notifications
You must be signed in to change notification settings - Fork 20
WNet + models code refactor #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 59.73% 68.19% +8.45%
==========================================
Files 48 51 +3
Lines 4555 5524 +969
==========================================
+ Hits 2721 3767 +1046
+ Misses 1834 1757 -77
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eb80a96 to
7463066
Compare
nastya236
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, the code is well written. + documentation to all classes!!
Well done! I commented the places in the code which could be (from my personal perspective) done a little bit more flexible.
Co-Authored-By: gityves <114951621+gityves@users.noreply.github.com>
- Fixed monai reqs - Added custom functions for label checking - Fixed return type of voronoi_otsu and utils.resize - black
- Remove unused scripts - More tests - Fixed weights type in inference
|
@MMathisLab Working on rebase now ! Thanks for the review. And yes, docs will be added, just thought I'd open the code for review |
Co-Authored-By: Markus Frey <5563464+CYHSM@users.noreply.github.com>
CYHSM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and very clean to me, just added some comments (can also discuss later)
PR adding WNet self-supervised model, and overhauled code for models usage
Note : merge to main after #34 has been merged (branch dependency)
-> WILL BE DONE IN OTHER PR : Improve ONNX support/UI/docs
and add pre-trained ONNX model to HF