Skip to content

Conversation

@C-Achard
Copy link
Collaborator

@C-Achard C-Achard commented Jul 25, 2023

Includes UI improvements and additions:

Improvements:

  • Results filepath is conserved across utils
  • Selected layer is retained when possible
  • Utils output creates a layer and updates it instead of making new layers
  • Bring above change to CRF

Additions:

  • Util to crop larger volumes into smaller cubes for training
  • Tests + coverage -> done in WNet training  #47

- Set new results path now remains across utils
- Utils generate one layer and update it on subsequent runs
- Layer choice tries to be conserved across utils
@C-Achard C-Achard added enhancement New feature or request UI Related to the UI labels Jul 25, 2023
@C-Achard C-Achard self-assigned this Jul 25, 2023
@C-Achard C-Achard changed the title Improved Utilities [WIP] Improved Utilities Jul 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (cy/training@1971d8d). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             cy/training      #44   +/-   ##
==============================================
  Coverage               ?   80.95%           
==============================================
  Files                  ?       45           
  Lines                  ?     4924           
  Branches               ?        0           
==============================================
  Hits                   ?     3986           
  Misses                 ?      938           
  Partials               ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@C-Achard C-Achard marked this pull request as ready for review August 3, 2023 10:00
@C-Achard C-Achard changed the title [WIP] Improved Utilities Improved Utilities Aug 3, 2023
@C-Achard C-Achard requested a review from jeylau August 7, 2023 10:40
push:
branches:
- main
- cy/utils
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you add a temporary branch here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this PR targets another branch that is not main, the "on PR" condition is not fulfilled in Actions. So I'm overriding manually, this will be removed when I start merging all the PRs (which depend on each other)

C-Achard and others added 4 commits August 9, 2023 16:32
Co-authored-by: Jessy Lauer <30733203+jeylau@users.noreply.github.com>
Co-authored-by: Jessy Lauer <30733203+jeylau@users.noreply.github.com>
@C-Achard C-Achard requested a review from jeylau August 10, 2023 08:46
@C-Achard C-Achard merged commit 7a4e31f into cy/training Sep 19, 2023
@C-Achard C-Achard deleted the cy/utils branch December 14, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request UI Related to the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants