Skip to content

[WIP] Initial upgrade to decorators state 2#646

Closed
josemarluedke wants to merge 3 commits intoAddepar:masterfrom
josemarluedke:jl-decorators-v2
Closed

[WIP] Initial upgrade to decorators state 2#646
josemarluedke wants to merge 3 commits intoAddepar:masterfrom
josemarluedke:jl-decorators-v2

Conversation

@josemarluedke
Copy link
Contributor

@josemarluedke josemarluedke commented Dec 25, 2018

This is an initial stab at upgrading to latest ember-decorators + babel 7.

This addon is breaking our app where another addon is using decorators state 2, probably because of the old dependency here of @ember-decorators/babel-transforms.

Also, I need to confirm that the changes related to @ember-decorators/argument are correct. Essentially the option defaultIfUndefined is not available anymore.

@josemarluedke
Copy link
Contributor Author

I'm getting the following error from @ember-decorators/argument.

object.js:20 Uncaught TypeError: Cannot convert undefined or null to object
    at Function.getOwnPropertyDescriptor (<anonymous>)

screen shot 2019-01-04 at 5 46 26 pm

Is anyone more familiar with this to help out?

@cyril-sf
Copy link
Contributor

@josemarluedke Do you still get the same error if you rebase?

@josemarluedke
Copy link
Contributor Author

I think this can be closed as State 2 decorators are not moving forward. We can keep using stage 1 decorators. See emberjs/rfcs#440.

@josemarluedke
Copy link
Contributor Author

It would still be nice to have babel 7 and etc. But it make sense to be a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants