[WIP] Initial upgrade to decorators state 2#646
Closed
josemarluedke wants to merge 3 commits intoAddepar:masterfrom
Closed
[WIP] Initial upgrade to decorators state 2#646josemarluedke wants to merge 3 commits intoAddepar:masterfrom
josemarluedke wants to merge 3 commits intoAddepar:masterfrom
Conversation
98cd55f to
568a733
Compare
Contributor
Author
1 task
Contributor
|
@josemarluedke Do you still get the same error if you rebase? |
Contributor
Author
|
I think this can be closed as State 2 decorators are not moving forward. We can keep using stage 1 decorators. See emberjs/rfcs#440. |
Contributor
Author
|
It would still be nice to have babel 7 and etc. But it make sense to be a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is an initial stab at upgrading to latest ember-decorators + babel 7.
This addon is breaking our app where another addon is using decorators state 2, probably because of the old dependency here of
@ember-decorators/babel-transforms.Also, I need to confirm that the changes related to
@ember-decorators/argumentare correct. Essentially the optiondefaultIfUndefinedis not available anymore.