some backwards-compatible closure action usage (#614)#744
Conversation
start to fix #614. The way I safely check for the action feels repetitive so am open to better approaches.
|
Would love to see this move forward |
ghost
changed the title
Author
|
@bantic I won't have time to continue working on this. Let me know if you would like me to close it / write up an issue with the action steps. I don't want to clutter the open pull requests. |
ghost
deleted the
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
start to fix #614.
The way I safely check for the action feels repetitive so am open to
better approaches.
I noticed 2 forks of ember-table solve this so I think it makes sense to add backwards compatibility into the addon. I followed Chris's comment.