Scroll indicator fixes#821
Merged
kpfefferle merged 2 commits intokpfefferle/scroll-indicatorsfrom May 6, 2020
Merged
Conversation
…ditional test-support for calculated scrollbar width.
box shadow for scroll indicators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated some calculations to account for scrollbar offset.
There were some issues with the scrollbar-y causing the box shadow to be improperly placed on the outside of the table area. Since we're already getting the boundRects for the elements in play and using them in calculations, it's easy to calculate the scrollbar width and accommodate for it.
Additionally, the scrollbar caused the shadow to stay on the box even when scrolled all the way to the end since the scrollbar-y made it impossible to horizontally scroll the full pixels distance required to meet the criteria to switch it off.
Included 2 integration tests to cover relevant scrollbar cases with and without frozen rows