Conversation
twokul
force-pushed
the
twokul/bump-ember-cli-sass
branch
from
88b0e3d to
3fcc61b
Compare
mixonic
reviewed
Aug 7, 2020
| "release-it": "^12.3.4" | ||
| }, | ||
| "engines": { | ||
| "node": "8.* || >= 10.*" |
Member
There was a problem hiding this comment.
This would require a major version bump re: semver
Member
|
And perhaps we also drop Ember < 2.4 from ember-try and then release the major. We could leave it all on a long-lived branch and do a pre-release |
mixonic
requested changes
Aug 7, 2020
Co-authored-by: Matthew Beale <matt.beale@addepar.com>
Co-authored-by: Matthew Beale <matt.beale@addepar.com>
mixonic
approved these changes
Aug 7, 2020
bantic
pushed a commit
that referenced
this pull request
Nov 6, 2020
* Bump `ember-cli-sass` to `10` * Update `@addepar/style-box` * Update package.json Co-authored-by: Matthew Beale <matt.beale@addepar.com> * Update .travis.yml Co-authored-by: Matthew Beale <matt.beale@addepar.com> Co-authored-by: Matthew Beale <matt.beale@addepar.com>
NullVoxPopuli
pushed a commit
to NullVoxPopuli/ember-table
that referenced
this pull request
Feb 2, 2021
* Bump `ember-cli-sass` to `10` * Update `@addepar/style-box` * Update package.json Co-authored-by: Matthew Beale <matt.beale@addepar.com> * Update .travis.yml Co-authored-by: Matthew Beale <matt.beale@addepar.com> Co-authored-by: Matthew Beale <matt.beale@addepar.com>
johanrd
pushed a commit
to johanrd/ember-table
that referenced
this pull request
Feb 25, 2021
* Bump `ember-cli-sass` to `10` * Update `@addepar/style-box` * Update package.json Co-authored-by: Matthew Beale <matt.beale@addepar.com> * Update .travis.yml Co-authored-by: Matthew Beale <matt.beale@addepar.com> Co-authored-by: Matthew Beale <matt.beale@addepar.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
ember-cli-sassto1012+Once and if this change lands, we should probably release a major version.