Merged
Conversation
twokul
approved these changes
Aug 7, 2020
mixonic
force-pushed
the
mixonic/drop-ember-before-2.4
branch
11 times, most recently
from
0916cca to
246cd79
Compare
Also drop un-used XHR mocking dependencies, and pin a dependency of ember-cli-addon-docs per ember-cli/ember-fetch#547 (which could alternatively be resolved by upgrading ember-cli-addon-docs to ^8.0.2)
mixonic
force-pushed
the
mixonic/drop-ember-before-2.4
branch
from
246cd79 to
456c4c8
Compare
mixonic
commented
Aug 10, 2020
| "ember-fetch": "^6.4.0", | ||
| "ember-load-initializers": "^2.0.0", | ||
| "ember-math-helpers": "^2.10.0", | ||
| "ember-math-helpers": "~2.11.3", |
Member
Author
There was a problem hiding this comment.
This was required since ember-math-helpers bumps major version number of ember-cli-htmlbars in minor releases. To continue supporting Ember 2.x via bower (as we do in Ember try), 2.11.x is the last version of ember-math-helpers this codebase can depend on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally:
^8.0.2which likely means upgrading ember-cli-addon-docs)