Use scrollLeft to detect when scroll indicators should appear#853
Closed
ahmacleod wants to merge 3 commits intoAddepar:3.0-betafrom
Closed
Use scrollLeft to detect when scroll indicators should appear#853ahmacleod wants to merge 3 commits intoAddepar:3.0-betafrom
ahmacleod wants to merge 3 commits intoAddepar:3.0-betafrom
Conversation
kpfefferle
approved these changes
Jan 14, 2021
Member
kpfefferle
left a comment
kpfefferle
left a comment
There was a problem hiding this comment.
I tested this out in my consuming app, and it seems to work well. This seems like a more robust solution for the long-term since it accounts for this additional use case 👍🏻
Contributor
Author
|
Made redundant by #854 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the table element has a negative
margin-leftstyle, the left scroll indicator will always show, even when scrolled all the way to the left. This negative margin trick is commonly used in conjunction withborder-spacingand an overflow element in order to eliminate leading whitespace in the leftmost column of a table (border-spacingcannot be overridden at a cell level).By examining
scrollLeftinstead of the bounding box positions of the table & overflow elements, the same effect is achieved without making any assumptions about the relative positions of elements.