Merged
Conversation
- Add Addressfinder 1.15.0 release notes to CHANGELOG - Correct build status badge URL in README
vprigent
commented
Mar 23, 2025
| def verify_address(address) | ||
| return if address.empty? | ||
|
|
||
| AddressFinder::V2::Au::Verification.new(q: address, http: http.clone, **args).perform.result || false |
Contributor
Author
There was a problem hiding this comment.
both AU and NZ verification classes here will assign result only if the address is matched.
This means there's not way of knowing if an address is verified and has returned no result or if there's simply no address to verify.
Because of how we currently bulk verify addresses, an empty value within the column gets sent to the API, and results in an error within our reporting.
erikfercak
approved these changes
Mar 24, 2025
|
|
||
| [](http://badge.fury.io/rb/addressfinder) | ||
| [](https://travis-ci.com/github/AddressFinder/addressfinder-ruby) | ||
| [](https://github.com/addressfinder/addressfinder-ruby/actions/workflows/ruby.yml/badge.svg?branch=master) |
vprigent
force-pushed
the
improve-bulk-handling-of-empty-values
branch
from
bf70816 to
2ff0b31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.