Skip to content

Comments

Update place-order.md#455

Closed
aplapana wants to merge 3 commits intoAdobeDocs:mainfrom
aplapana:patch-1
Closed

Update place-order.md#455
aplapana wants to merge 3 commits intoAdobeDocs:mainfrom
aplapana:patch-1

Conversation

@aplapana
Copy link

@aplapana aplapana commented Jun 30, 2025

https://jira.corp.adobe.com/browse/ACP2E-4046

Purpose of this pull request

Address changes in placeOrder mutation introduced in: https://jira.corp.adobe.com/browse/ACP2E-3399

Affected pages

Links to Magento Open Source code

  • ...

Address changes introduced in ACP2E-3659
@keharper
Copy link
Contributor

@aplapana You mentioned an incorrect ticket in the description. Please provide a link to the correct ticket. If you opened this PR as a result of a code change, link to that as well.

@aplapana
Copy link
Author

aplapana commented Jul 1, 2025

@aplapana You mentioned an incorrect ticket in the description. Please provide a link to the correct ticket. If you opened this PR as a result of a code change, link to that as well.

Updated description with the proper ticket links

@keharper
Copy link
Contributor

keharper commented Jul 7, 2025

@aplapana I need you to make the following changes:

  • Rebase from main to 2.4.9-develop
  • Add a new paragraph below line 20 stating that as of 2.4.9, the errors data type was removed from PlaceOrderOutput and that errors are now returned at the top of the response.
  • Remove the example that you added.

@aplapana
Copy link
Author

aplapana commented Jul 8, 2025

@keharper

Can you please hold off any changes just yet ? I think we will modify the solution a little bit - intstead of removing the error structure completly we will introduce a new mutation and deprecate this one. I will have a call with the PO today to sort this out. Will update the documentation changes again once we have a clear picture.

Adjusted example error response, based on ACP2E-4031 conclusion
@aplapana
Copy link
Author

@keharper addressed latest development from ACP2E-4031

@aplapana
Copy link
Author

New PR: #470

@aplapana aplapana closed this Jul 28, 2025
@github-project-automation github-project-automation bot moved this from 📋 Needs Review to 🏁 Done in Commerce - Pull Requests Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants