Create the ultimate minesweeper#3
Open
dakotasanchez wants to merge 1 commit intoAdvancedProgrammingWithJavaSummer2017:masterfrom
dakotasanchez:master
Open
Create the ultimate minesweeper#3dakotasanchez wants to merge 1 commit intoAdvancedProgrammingWithJavaSummer2017:masterfrom dakotasanchez:master
dakotasanchez wants to merge 1 commit intoAdvancedProgrammingWithJavaSummer2017:masterfrom
dakotasanchez:master
Conversation
Member
DavidWhitlock
left a comment
DavidWhitlock
left a comment
There was a problem hiding this comment.
Looks like you got off to a good start!
👍
| if (row == 0 || column == 0) { | ||
| throw new ZeroSizedBoardException(); | ||
| } | ||
| this.inputBoard = new char[row][column]; |
Member
There was a problem hiding this comment.
Interesting choice of data structure. I wonder if an ArrayList would be easier to work with.
| } | ||
|
|
||
| public String solve() { | ||
| // for (int i = 0; i < inputBoard.length; i++) { |
Member
There was a problem hiding this comment.
Heh. It's hard to resist implementing, isn't it? 😈
| @Ignore | ||
| @Test(expected = ZeroSizedBoardException.class) | ||
| public void zeroSizedBoardThrowException() { | ||
| public void zeroSizedBoardThrowException() throws ZeroSizedBoardException { |
Member
There was a problem hiding this comment.
I recommend using making ZeroSizedBoardException a RuntimeException so that you don't to declare it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added "AddRow" method.
Fixed improper 2 space indenting to a more dignified 4 spaces.