Skip to content

Conversation

@jeandersonbc
Copy link
Contributor

@jeandersonbc jeandersonbc commented Jan 12, 2026

Add the generated capital-related service and exports to the client.
In addition, the changes add test coverage for simple flows and assertions over endpoints.
README file updated with Capital description.

@jeandersonbc jeandersonbc self-assigned this Jan 12, 2026
@jeandersonbc jeandersonbc requested review from a team as code owners January 12, 2026 14:07
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jeandersonbc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Adyen Python client by integrating the Capital API, enabling developers to interact with its services directly through the main Adyen object. It also introduces a dedicated suite of unit tests, ensuring the reliability and correctness of the newly exposed Capital API functionalities and their interactions within the client library.

Highlights

  • Capital API Integration: The AdyenCapitalApi service has been fully integrated into the main Adyen client, making it accessible for use.
  • Client Configuration Update: The Adyen client now supports an api_capital_version parameter, allowing for specific versioning of Capital API calls.
  • Comprehensive Test Coverage: Extensive unit tests have been added for various Capital API endpoints, including grant requests, offer retrieval, grant management, disbursement tracking, and account information.
  • Mock Data for Testing: New JSON mock response files have been introduced to facilitate robust and isolated testing of the Capital API functionalities.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the Capital API and introduces a suite of tests for its basic flows. The changes to integrate the new API in Adyen/__init__.py and Adyen/client.py are correct and follow the existing pattern for other services.

The new test file test/CapitalTest.py provides good coverage for the new API endpoints. However, I've identified a couple of areas for improvement to enhance test quality, maintainability, and adherence to standard testing practices:

  • The test class setup can be improved by using the setUp method to ensure test isolation.
  • Some tests define a request variable that is not used in the API call under test, which can be confusing. Inlining this value would improve clarity.

Please see the detailed comments for specific suggestions.

Add the generated capital-related service and exports to the client.
In addition, the changes add test coverage for simple flows and assertions over endpoints.
README file updated with Capital description.
@jeandersonbc jeandersonbc force-pushed the add-coverage-capital-api branch from 452c16d to c624c35 Compare January 12, 2026 15:58
@jeandersonbc jeandersonbc changed the base branch from sdk-automation/models to main January 12, 2026 15:58
@sonarqubecloud
Copy link

@jeandersonbc jeandersonbc changed the title Added test coverage for simple flows in CapitalApi Introduce Capital API Service Jan 12, 2026
@jeandersonbc jeandersonbc merged commit 2b69f03 into main Jan 12, 2026
2 checks passed
@jeandersonbc jeandersonbc deleted the add-coverage-capital-api branch January 12, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants