-
Notifications
You must be signed in to change notification settings - Fork 47
Introduce Capital API Service #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jeandersonbc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Adyen Python client by integrating the Capital API, enabling developers to interact with its services directly through the main Adyen object. It also introduces a dedicated suite of unit tests, ensuring the reliability and correctness of the newly exposed Capital API functionalities and their interactions within the client library. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the Capital API and introduces a suite of tests for its basic flows. The changes to integrate the new API in Adyen/__init__.py and Adyen/client.py are correct and follow the existing pattern for other services.
The new test file test/CapitalTest.py provides good coverage for the new API endpoints. However, I've identified a couple of areas for improvement to enhance test quality, maintainability, and adherence to standard testing practices:
- The test class setup can be improved by using the
setUpmethod to ensure test isolation. - Some tests define a
requestvariable that is not used in the API call under test, which can be confusing. Inlining this value would improve clarity.
Please see the detailed comments for specific suggestions.
Add the generated capital-related service and exports to the client. In addition, the changes add test coverage for simple flows and assertions over endpoints. README file updated with Capital description.
452c16d to
c624c35
Compare
|



Add the generated capital-related service and exports to the client.
In addition, the changes add test coverage for simple flows and assertions over endpoints.
README file updated with Capital description.