Skip to content

[BUGS]: Some quick i/o bugfixes#162

Merged
aaronjridley merged 5 commits intoion_vertical_advectionfrom
io_bugfixes
Mar 9, 2025
Merged

[BUGS]: Some quick i/o bugfixes#162
aaronjridley merged 5 commits intoion_vertical_advectionfrom
io_bugfixes

Conversation

@abukowski21
Copy link
Collaborator

@abukowski21 abukowski21 commented Jan 7, 2025 •
edited
Loading

Make sure dt is specified for each output type, and change default inputs

Some super minor bug fixes. And a little new feature:

  • If there were more output types than dt's, there would be an out-of-range json error and no more info. this catches those errors.
  • Cent_acc was not included in the default input file
    • Centripetal and Cent_acc are both checked? IDK if this is right.
    • See here. Centripetal is not used, only calc_cent_acc - in main
  • If Ions output type is specified, output the magnetic coordinates
    • MLT is not right, but the magnetic coordinates are output

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)

How Has This Been Tested?

Tested with correct, and incorrect input files. Errors were caught correctly.

Test configuration

-WSL Ubuntu gcc/g++ 13

Checklist:

  • [N/A] Make sure you are merging into the develop (not master) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [N/A] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [N/A] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • [N/A] Add a note to CHANGELOG.md, summarizing the changes

@abukowski21
BUG: Centripetal acceleration is checked, but not included in input f…
22ef72b 
…iles.

This seems redundant, since  "Centripetal" is also checked, but this prevents the error...

Mayber instead we should check just one or the other.
@abukowski21
BUG: If outputting from main fails, note that it's the "initial" output
194853b
@abukowski21
BUG: Check output "dt" separately from "type", allows us to make sure…
d1137ee 
… each type has a dt

> Otherwise, there are out-of-range json errors with mo more info.
@abukowski21
FEAT: Check if dt was specified for each output type (better error ha…
cfdabb0 
…ndling)
@abukowski21
FEAT: if "ion" output type is specified, output magnetic coordinates
58c1f4e 
> I really wanted to get these out. That's why I did all those previous commits.
@abukowski21
Copy link
Collaborator Author

abukowski21 commented Jan 7, 2025

SUPER minor changes here. Wanted to get them into the most recently active branch rather than develop to prevent merge conflicts later.

@abukowski21 abukowski21 marked this pull request as ready for review January 7, 2025 21:22
@aaronjridley aaronjridley merged commit 5b7f90c into ion_vertical_advection Mar 9, 2025
6 checks passed
@abukowski21 abukowski21 deleted the io_bugfixes branch March 10, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaronjridley aaronjridley Awaiting requested review from aaronjridley

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abukowski21 @aaronjridley