Deciding the range of frame used for the 3D reconstruction#11
Merged
Deciding the range of frame used for the 3D reconstruction#11
Conversation
zicodasilva
reviewed
May 10, 2021
| parser.add_argument('--plot', action='store_true', help='Show the plots') | ||
| parser.add_argument('--data_dir', type=str, help='The file path to the flick/run to be optimized.') | ||
| parser.add_argument('--start_frame', type=int, default=1, help='The frame at which the optimized reconstruction will start.') | ||
| parser.add_argument('--end_frame', type=int, default=-1, help='The frame at which the optimized reconstruction will end. If it is -1, start_frame and end_frame are automatically set.') |
There was a problem hiding this comment.
It might be better if we use the start_frame as the trigger for the automatic frame selection. That way we can use end_frame=-1 as an indication to use the entire video. So we have the options to:
- Manually set
start_frameandend_frameto values> 0. - Use the entire video segment by setting
end_frame = -1. - Automatically select the "best" frames based on the first time (and last time) the markers are all visible by setting
start_frame = -1.
Just a thought.
|
As I understand it, this will select a start frame where all the markers are visible (from any set of camera view points) and do the same from the other side for the end frame. I think this is a good way to select the frames that would produce the best reconstruction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
args.end_frameis set-1, thestart_frameandend_frameare automatically defined with the following process:line 812 on
all_optimizations.py.