Feature/typescript didclient vc methods#462
Merged
AbirAbbas merged 4 commits intoAgent-Field:mainfrom Apr 22, 2026
Merged
Conversation
Contributor
Performance
✓ No regressions detected |
Contributor
📊 Coverage gateThresholds from
✅ Gate passedNo surface regressed past the allowed threshold and the aggregate stayed above the floor. |
Contributor
📐 Patch coverage gateThreshold: 80% on lines this PR touches vs
✅ Patch gate passedEvery surface whose lines were touched by this PR has patch coverage at or above the threshold. |
AbirAbbas
reviewed
Apr 20, 2026
…Credential The control plane's VCVerificationRequest only binds vc_document, so the optional signature argument was silently dropped by the server. Align the TypeScript surface with the Python VCGenerator, which omits it as well. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds verifyCredential, getWorkflowVcChain, and createWorkflowVc to the TypeScript DidClient, aligned with the Python VCGenerator API and behavior.
Also adds unit tests for the new DID client methods and extends integration (E2E) tests to cover the full VC flow through the SDK (generation, aggregation, retrieval, and verification).
Testing
./scripts/test-all.shcd sdk/typescript && npm test -- tests/did_client_methods.test.ts tests/integration.e2e.test.ts
cd sdk/typescript && npm run lint
Unit tests (did_client_methods.test.ts):
Integration tests (integration.e2e.test.ts):
Checklist
Screenshots (if UI-related)
N/A
Related issues
Fixes #92