Skip to content

Relax lint failures and fix async tests #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
santoshkumarradha merged 3 commits into from
Nov 11, 2025
+18 −4
Merged

Relax lint failures and fix async tests #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1b4621
Stabilize async CI workflows
santoshkumarradha Nov 11, 2025
fabbece
Appease gosimple warnings
santoshkumarradha Nov 11, 2025
d17f81d
Merge branch 'main' into santosh/async-relations
santoshkumarradha Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/control-plane.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion .github/workflows/sdk-python.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions control-plane/internal/handlers/workflow_execution_events.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,10 @@ func applyEventToExecution(current *types.Execution, req *WorkflowExecutionEvent
current.RunID = firstNonEmpty(req.RunID, req.WorkflowID, current.RunID)
}

if payload := marshalJSON(req.InputData); payload != nil && len(payload) > 0 {
if payload := marshalJSON(req.InputData); len(payload) > 0 {
current.InputPayload = payload
}
if result := marshalJSON(req.Result); result != nil && len(result) > 0 {
if result := marshalJSON(req.Result); len(result) > 0 {
current.ResultPayload = result
}

Expand Down
10 changes: 9 additions & 1 deletion sdk/python/tests/test_agent_field_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,15 @@ async def test_register_with_agentfield_applies_discovery_payload(monkeypatch):
agent, agentfield_client = create_test_agent(monkeypatch)
agent.callback_candidates = []

async def fake_register(node_id, reasoners, skills, base_url, discovery=None, vc_metadata=None):
async def fake_register(
node_id,
reasoners,
skills,
base_url,
discovery=None,
vc_metadata=None,
**kwargs,
):
return True, {
"resolved_base_url": "https://public:9000",
"callback_discovery": {
Expand Down
Loading