feat(tui): convert /skills to sub-page overlay#109
Closed
yishuiliunian wants to merge 4 commits intomainfrom
Closed
feat(tui): convert /skills to sub-page overlay#109yishuiliunian wants to merge 4 commits intomainfrom
yishuiliunian wants to merge 4 commits intomainfrom
Conversation
Replace inline system message with a full SubPage (left list + right detail pane), matching the /mcp page pattern. Also fix scroll tracking in both skills and mcp list views so the selected item stays visible.
yishuiliunian
force-pushed
the
feat/skills-sub-page
branch
from
020feec to
edbf583
Compare
yishuiliunian
force-pushed
the
feat/skills-sub-page
branch
from
edbf583 to
195e956
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/skillsslash command from inline system message to a full SubPage overlay (left list + right detail pane), matching the/mcppage patternSkillsPageState,SkillItemtypes, view renderer, key handler, and 11 testsChanges
app/skills_page.rs,views/skills_page.rs,input/skills_page_keys.rs,tests/suite/skills_page_keys_test.rsskills_cmd.rs(core logic),types.rs(SubPage enum),render.rs,sub_page.rs,mcp_page.rs(scroll fix),mod.rsfiles,suite.rs,skills_cmd_test.rsTest plan
bazel test //crates/loopal-tui:loopal-tui_test— all passbazel build //crates/loopal-tui --config=clippy— zero warnings