PROBLEM
In .github/workflows/offline_tests/yml we run the tests found in src/sherpa_ai. This is good. However, we do not run the Slackapp tests, which are found in src/apps/slackapp/tests.
SOLUTION
Update offline_tests.yml as follows:
- Change working directory to
src/apps/slackapp/
- Install poetry and dependencies in the slackapp directory, similar to what we do already for sherpa_ai
- Run slackapp tests:
poetry run pytest --cov=slackapp tests
Or take a dependency on #343 and instead of steps 2 and 3, just run make test. That would be a nice way of DRYing up the offline tests action.
OUTCOME
- Increased test coverage
- Some insurance that changes do not break the Slack app
PROBLEM
In
.github/workflows/offline_tests/ymlwe run the tests found insrc/sherpa_ai. This is good. However, we do not run the Slackapp tests, which are found insrc/apps/slackapp/tests.SOLUTION
Update offline_tests.yml as follows:
src/apps/slackapp/poetry run pytest --cov=slackapp testsOr take a dependency on #343 and instead of steps 2 and 3, just run
make test. That would be a nice way of DRYing up the offline tests action.OUTCOME