This repository was archived by the owner on Feb 12, 2025. It is now read-only.
coordinator: Make cleanup keep only interesting manifests #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingon
commented
Nov 29, 2023
|
|
||
|
|
||
| def _prune_manifests(manifests: List[ipc.BackupManifest], retention: Retention) -> List[ipc.BackupManifest]: | ||
| manifests = sorted(manifests, key=lambda m: (m.start, m.end, m.filename), reverse=True) |
Contributor
Author
There was a problem hiding this comment.
NB: Not sure if some later step makes assumptions about order -> sort even if we don't change the list here. Also, while this sorts list every time manifest is inserted, we have only tens of backup manifests at most so I didn't go for e.g. biject module's sorted insert.
Contributor
There was a problem hiding this comment.
Checked all 3 instances of context.get_result(ComputeKeptBackupsStep) and all operations are essentially on sets, so no ordering issue expected there.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
=======================================
Coverage 87.31% 87.32%
=======================================
Files 141 141
Lines 10035 10040 +5
=======================================
+ Hits 8762 8767 +5
Misses 1273 1273 ☔ View full report in Codecov by Sentry. |
The endgame we really want is adding per-node manifests and some sort of summary manifest to be handled here, not keeping the 'too old' manifests in memory helps a lot in case of nodes which have already taken too many backups. With this, we will load only up to the <amount kept+1> manifests to memory at most, so having e.g. 70 manifests in object storage and 5 kept means we at most have 6 in memory at a time. (As seen in production.)
fingon
force-pushed
the
mst-memory-efficient-cleanup
branch
from
4a3c130 to
3429f28
Compare
kmichel-aiven
approved these changes
Nov 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endgame we really want is adding per-node manifests and some sort of summary manifest to be handled here, not keeping the 'too old' manifests in memory helps a lot in case of nodes which have already taken too many backups.
With this, we will load only up to the <amount kept+1> manifests to memory at most, so having e.g. 70 manifests in object storage and 5 kept means we at most have 6 in memory at a time.
(As seen in production.)